A20:29
I used to feel nervous in code reviews.
I used to feel nervous in code reviews.
I worried my comments would sound mean.
I worried my comments would sound mean.
Now I start with a question.
Now I start with a question.
I say, 'What do you think about this part?'
I say, 'What do you think about this part?'
Yesterday I reviewed my teammate's pull request.
Yesterday I reviewed my teammate's pull request.
I saw a small issue with the loop.
I saw a small issue with the loop.
I wrote, 'One small suggestion for clarity.'
I wrote, 'One small suggestion for clarity.'
He replied, 'Good call, let me fix that.'
He replied, 'Good call, let me fix that.'
That felt good.
That felt good.
We both learned something.
We both learned something.
Now I see feedback as teamwork.
Now I see feedback as teamwork.
How I Learned to Give Code Feedback Calmly
by @ruby_10