Spikdi
A2–B10:31
A2–B10:31
Yesterday, I reviewed my teammate's code changes.
Yesterday, I reviewed my teammate's code changes.
I saw a small bug in the login part.
I saw a small bug in the login part.
I wanted to say it without hurting his feelings.
I wanted to say it without hurting his feelings.
So I wrote: 'What do you think about this line?'
So I wrote: 'What do you think about this line?'
Then I added one small suggestion.
Then I added one small suggestion.
I said, 'Maybe we can check the input first.'
I said, 'Maybe we can check the input first.'
He read it and said, 'Good call, let me fix that.'
He read it and said, 'Good call, let me fix that.'
He fixed the bug in ten minutes.
He fixed the bug in ten minutes.
No one felt upset or angry.
No one felt upset or angry.
Feedback is easier when we ask, not tell.
Feedback is easier when we ask, not tell.
I will use this way again next time.
I will use this way again next time.
How I Gave and Got Code Feedback Without Drama
by @theodaily