Spikdi
B10:39
B10:39
Last week, I reviewed a teammate's code.
上周,我review了队友的代码。
I saw a small logic problem in it.
我发现里面有个小逻辑问题。
I said, "What do you think about moving this line?"
我说:“你觉得把这行移动一下怎么样?”
I kept my tone friendly and simple.
我保持友好简单的语气。
I also added, "One small suggestion: maybe rename this variable."
我还说:“一个小建议:也许可以重命名这个变量。”
My teammate listened and nodded.
我的队友听了并点头。
She said, "Good call, let me fix that."
她说:“好主意,我来改一下。”
It felt okay, not personal.
感觉还好,不是个人攻击。
I learned that wording matters a lot.
我学到措辞很重要。
When I receive feedback, I stay open.
当我收到反馈时,我保持开放。
I say thank you and ask questions.
我说谢谢并问问题。
This way, we all improve together.
这样,我们一起进步。
Giving and Taking Code Review Feedback Without It Feeling Personal
by @jianguo_52