Spikdi
B10:35
B10:35
My colleague commented on my pull request yesterday.
我同事昨天评论了我的代码提交。
She said, 'What do you think about simplifying this loop?'
她说:“你觉得简化这个循环怎么样?”
At first I felt defensive.
一开始我觉得有点防备。
But I took a breath and read it again.
但我深吸一口气,又读了一遍。
She was right — it was cleaner that way.
她是对的——那样更简洁。
I replied, 'Good call, let me fix that.'
我回复说:“好主意,我来改。”
Then I reviewed her code and found a small bug.
然后我审查了她的代码,发现了一个小缺陷。
I wrote, 'One small suggestion: maybe check this edge case.'
我写道:“一个小建议:也许检查一下这个边界情况。”
She thanked me and fixed it quickly.
她感谢了我,并很快修复了。
We both stayed focused on the code, not each other.
我们都专注于代码本身,而不是针对个人。
That is the goal for me in every review.
这是我在每次审查中的目标。
It is about making the product better together.
这是关于一起让产品变得更好。
欣怡
Reflecting on a code review exchange that stayed professional
by @xinyi_52