A20:31
Yesterday, I reviewed a teammate's code.
昨天,我检查了一位同事的代码。
I found a small bug in a loop.
我在一个循环里发现了一个小错误。
I said, 'What do you think about this line?'
我说:“你觉得这一行怎么样?”
I did not say 'this is wrong.'
我没有说“这是错的。”
Then I added, 'One small suggestion.'
然后我加了一句:“一个小建议。”
They said, 'Good call, let me fix that.'
他们说:“好主意,我来改一下。”
I felt happy. No one got upset.
我很开心。没人不开心。
Later, someone reviewed my code.
后来,有人检查了我的代码。
They asked, 'Why did you use this function?'
他们问:“你为什么用这个函数?”
I listened and thought about it.
我听了,想了想。
I said, 'Good point. I will change it.'
我说:“有道理。我来改。”
Feedback is not personal. It helps the team.
反馈不是针对个人。它帮助团队。
Learning to Give and Take Code Feedback
by @jiayisays